Skip to content

Guard against flaky SimpliSafe API calls#59175

Merged
balloob merged 1 commit intohome-assistant:devfrom
bachya:ss-guard-flaky-api
Nov 7, 2021
Merged

Guard against flaky SimpliSafe API calls#59175
balloob merged 1 commit intohome-assistant:devfrom
bachya:ss-guard-flaky-api

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Nov 5, 2021

Proposed change

This PR expands the SimpliSafe integration's current "guard against flaky API calls" logic to every entity. Now, multiple concurrent API requests will need to fail before marking entities as unavailable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit 8ebd47b into home-assistant:dev Nov 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2021
@bachya bachya deleted the ss-guard-flaky-api branch November 9, 2021 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All SimpliSafe sensors return "offline" status at the top of the hour

3 participants