Skip to content

Velbus: Use EntityDescription for sensors, Finish typing#59078

Closed
cereal2nd wants to merge 1 commit intohome-assistant:devfrom
cereal2nd:velbusEntityDescription
Closed

Velbus: Use EntityDescription for sensors, Finish typing#59078
cereal2nd wants to merge 1 commit intohome-assistant:devfrom
cereal2nd:velbusEntityDescription

Conversation

@cereal2nd
Copy link
Copy Markdown
Contributor

@cereal2nd cereal2nd commented Nov 4, 2021

Proposed change

  • Finish typing the whole module
  • Switch the sensor platform to work with EnityDescriptions

Note: this is dependant on #58622

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @brefra, mind taking a look at this pull request as it has been labeled with an integration (velbus) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@cereal2nd cereal2nd marked this pull request as draft November 4, 2021 15:54
@cereal2nd cereal2nd marked this pull request as ready for review November 4, 2021 18:08
@MartinHjelmare
Copy link
Copy Markdown
Member

Please split the PR into two PRs. One for completing typing and one for adding entity descriptions.

@cereal2nd cereal2nd closed this Nov 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2021
@cereal2nd cereal2nd deleted the velbusEntityDescription branch September 26, 2022 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants