Skip to content

Add tests for KNX light#58912

Merged
marvin-w merged 3 commits intohome-assistant:devfrom
farmio:test-light
Nov 4, 2021
Merged

Add tests for KNX light#58912
marvin-w merged 3 commits intohome-assistant:devfrom
farmio:test-light

Conversation

@farmio
Copy link
Copy Markdown
Member

@farmio farmio commented Nov 1, 2021

Proposed change

Tests for KNX lights. 💡🤪

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@farmio farmio mentioned this pull request Nov 1, 2021
21 tasks
Copy link
Copy Markdown
Contributor

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @farmio!

@marvin-w marvin-w changed the title Test KNX light Add tests for KNX light Nov 4, 2021
@marvin-w marvin-w merged commit 4d4d778 into home-assistant:dev Nov 4, 2021
natekspencer pushed a commit to natekspencer/home-assistant-core that referenced this pull request Nov 5, 2021
* test lights: simple, brightness, color_temp

* hs, xyy, rgb individual

* test rgb, rgbw
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants