Closed
Conversation
tkdrob
requested review from
Danielhiversen,
Quentame,
andrewsayre,
balloob,
bieniu,
chemelli74,
frenck,
kellerza,
mib1185,
rohankapoorcom,
rytilahti and
thecode
as code owners
frenck
added
the
smash
frenck
requested changes
Oct 25, 2021
| """Initialize the instance.""" | ||
| self._device = device | ||
| self._dispatcher_remove = None | ||
| self._attr_device_info = DeviceInfo( |
Member
There was a problem hiding this comment.
This is a functional change, things like name won't update anymore. Was this intentional?
Contributor
Author
There was a problem hiding this comment.
I have smartthings and my testing confirms integration is functional as before except for the obvious, no name updates.
Member
There was a problem hiding this comment.
Ok, @andrewsayre as the codeowner of the smartthings integration, do you agree?
frenck
removed
the
smash
frenck
added
the
smash
Member
|
Not all comments have been processed. |
frenck
removed
the
smash
This was referenced Oct 27, 2021
This was referenced Oct 27, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use DeviceInfo Class S
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: