Added Mikrotik platform support for device_tracker#5830
Closed
xstasy wants to merge 1 commit into
Closed
Conversation
Contributor
houndci-bot
reviewed
Feb 9, 2017
| _LOGGER.info('Successfully connected to Mikrotik device') | ||
| self._update_info() | ||
| else: | ||
| _LOGGER.error('Failed to establish connection to Mikrotik device with IP: %s', self.host) |
There was a problem hiding this comment.
line too long (101 > 79 characters)
houndci-bot
reviewed
Feb 9, 2017
| vol.Optional(CONF_USERNAME, default=''): cv.string | ||
| }) | ||
|
|
||
| def get_scanner(hass, config): |
Contributor
|
Any updates on this PR? |
Contributor
|
@xstasy Daniel, do you plan to finish this PR? |
Contributor
|
I can say |
6 tasks
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Mikrotik Platform for Device Tracker
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.