Skip to content

Add service to trigger Shelly device firmware update#57005

Closed
johan12345 wants to merge 1 commit intohome-assistant:devfrom
johan12345:shelly-firmware-update
Closed

Add service to trigger Shelly device firmware update#57005
johan12345 wants to merge 1 commit intohome-assistant:devfrom
johan12345:shelly-firmware-update

Conversation

@johan12345
Copy link
Copy Markdown

Proposed change

Adds a new service to the Shelly integration that triggers a firmware upgrade on a Shelly device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I'm sorry that I implemented this before noticing that there actually has already been a PR for this feature (#48448) earlier this year.

As far as I understand, that PR has been closed due to the ongoing discussion in home-assistant/architecture#566. But, this is discussion is mainly about a new UI for managing firmware updates, which in the end will probably still trigger a service for actually triggering the update. Also, there are already other integrations implementing such a service (e.g. guardian). So I'm not sure why this shouldn't be implemented as a simple service in the meantime.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @johan12345,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @balloob, @bieniu, @thecode, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@thecode
Copy link
Copy Markdown
Member

thecode commented Oct 10, 2021

Hi @johan12345, since @mib1185 closed his issue due to our request due to active architecture discussion if we accept this type of PR it would be better to continue with his PR which was already a work in progress.
Also note that since we now support Gen2 devices (Shelly Plus/Pro series) we can't accept PRs which implement common functionality only to one of the generations (unless they are split into two PRs which are submitted together).
I think the best option for this is to work together with @mib1185 on a new PR, you can find him and me on discord.
Thanks.

@mib1185
Copy link
Copy Markdown
Member

mib1185 commented Oct 10, 2021

Hi @thecode
I will refresh my PR #48448 and check how to also integrate Gen2 devices.

@johan12345
Copy link
Copy Markdown
Author

Alright, thanks! I'll close this one then.

@johan12345 johan12345 closed this Oct 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants