Add service to trigger Shelly device firmware update#57005
Add service to trigger Shelly device firmware update#57005johan12345 wants to merge 1 commit intohome-assistant:devfrom
Conversation
|
Hi @johan12345, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Hey there @balloob, @bieniu, @thecode, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hi @johan12345, since @mib1185 closed his issue due to our request due to active architecture discussion if we accept this type of PR it would be better to continue with his PR which was already a work in progress. |
|
Alright, thanks! I'll close this one then. |
Proposed change
Adds a new service to the Shelly integration that triggers a firmware upgrade on a Shelly device.
Type of change
Additional information
I'm sorry that I implemented this before noticing that there actually has already been a PR for this feature (#48448) earlier this year.
As far as I understand, that PR has been closed due to the ongoing discussion in home-assistant/architecture#566. But, this is discussion is mainly about a new UI for managing firmware updates, which in the end will probably still trigger a service for actually triggering the update. Also, there are already other integrations implementing such a service (e.g.
guardian). So I'm not sure why this shouldn't be implemented as a simple service in the meantime.Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: