Skip to content

Fix incomfort min/max temperatures#55806

Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom
zxdavb:incomfort_bugfix
Sep 6, 2021
Merged

Fix incomfort min/max temperatures#55806
MartinHjelmare merged 3 commits intohome-assistant:devfrom
zxdavb:incomfort_bugfix

Conversation

@zxdavb
Copy link
Member

@zxdavb zxdavb commented Sep 5, 2021

Breaking change

Proposed change

Addresses issue #55534 - just swaps two floats 30.0 <--> 80.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Contributor

@acshef acshef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally a PR small enough to get my feet wet!
LGTM 😁👍

@MartinHjelmare MartinHjelmare changed the title bugfix incomfort min/max temperatures Fix incomfort min/max temperatures Sep 6, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2021.9.4 milestone Sep 6, 2021
@MartinHjelmare MartinHjelmare merged commit 67b7144 into home-assistant:dev Sep 6, 2021
balloob pushed a commit that referenced this pull request Sep 6, 2021
@balloob balloob mentioned this pull request Sep 6, 2021
@zxdavb zxdavb deleted the incomfort_bugfix branch September 7, 2021 06:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

temperature attributes are wrong

5 participants