Skip to content

Fix xiaomi miio Air Quality Monitor initialization#55773

Merged
MartinHjelmare merged 5 commits intohome-assistant:devfrom
bieniu:xiaomi_miio/fix_air_quality_monitor_init
Sep 6, 2021
Merged

Fix xiaomi miio Air Quality Monitor initialization#55773
MartinHjelmare merged 5 commits intohome-assistant:devfrom
bieniu:xiaomi_miio/fix_air_quality_monitor_init

Conversation

@bieniu
Copy link
Member

@bieniu bieniu commented Sep 5, 2021

Breaking change

Proposed change

XiaomiAirQualityMonitor doesn't use DataUpdateCoordinator so there is no config_entry.entry_id in hass.data[DOMAIN] during sensor platform initialization.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bieniu bieniu added this to the 2021.9.4 milestone Sep 5, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Fix Air Quality Monitor initialization Fix xiaomi miio Air Quality Monitor initialization Sep 6, 2021
@MartinHjelmare MartinHjelmare merged commit 9ee0d8f into home-assistant:dev Sep 6, 2021
@bieniu bieniu deleted the xiaomi_miio/fix_air_quality_monitor_init branch September 6, 2021 13:30
@balloob balloob mentioned this pull request Sep 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xiaomi Air Quality Monitor state show up as unknown

6 participants