Fix logbook entity_matches_only query mode#55761
Merged
balloob merged 1 commit intohome-assistant:devfrom Sep 6, 2021
Merged
Conversation
The string matching template needs to match the same compact JSON format as the data is now written in.
Contributor
Author
|
Change was implemented as per the approach suggested by @bdraco in #55724 (comment), so hopefully you could review @bdraco? |
3 tasks
bdraco
approved these changes
Sep 5, 2021
balloob
pushed a commit
that referenced
this pull request
Sep 6, 2021
The string matching template needs to match the same compact JSON format as the data is now written in.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way that logbook data is written to the database, versus how it is read, has gotten out of sync.
The two competing optimisations are:
No test covered this scenario.
This caused a regression in 2021.8, identified in #55724, where different query paths have inconsistent results.
Specifically, the Logbook panel displays more data than the Logbook card can.
Proposed change
Fixes #55724, which was a regression in 2021.8. This bug prevented custom log entries from displaying on the Logbook Lovelace card. They would only show on the Logbook panel, creating an inconsistent experience between the two. Now they are consistent again.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: