Skip to content

Add additional comfoconnect settings#55652

Closed
michaelarnauts wants to merge 11 commits intohome-assistant:devfrom
michaelarnauts:comfoconnect_preset_mode
Closed

Add additional comfoconnect settings#55652
michaelarnauts wants to merge 11 commits intohome-assistant:devfrom
michaelarnauts:comfoconnect_preset_mode

Conversation

@michaelarnauts
Copy link
Copy Markdown
Contributor

Proposed change

Adds preset_mode to the comfoconnect fan to switch between manual and auto mode.

In auto mode, the ventilation will change speed automatically, in manual mode, it will stick to the picked speed. It is still possible to change the speed when in auto mode, but it will fall back after two hours.

This has always been the way it worked, except that the mode wasn't visible or changeable in Home Assistant, so the behaviour depended on the mode that was configured in the Comfoconnect app.

Depends on #54066 to be merged first.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@michaelarnauts michaelarnauts force-pushed the comfoconnect_preset_mode branch from cf0c925 to f13b1d7 Compare September 3, 2021 15:20
@michaelarnauts michaelarnauts force-pushed the comfoconnect_preset_mode branch from f13b1d7 to 956b31b Compare September 10, 2021 11:09
@michaelarnauts
Copy link
Copy Markdown
Contributor Author

@switschel can you try this branch? There was an issue previously that might explain your issues.

@switschel
Copy link
Copy Markdown

@michaelarnauts: I'm disparately waiting for this branch to be merged into HA ;-) Any idea when you plan to change the status of this PR so it can be eventually merged?

@michaelarnauts
Copy link
Copy Markdown
Contributor Author

Sorry, I need to rewrite this so it exposes the preset mode as a separate switch as is explained here: https://developers.home-assistant.io/docs/core/entity/fan#preset-modes

@michaelarnauts michaelarnauts changed the title Comfoconnect preset mode Add additional comfoconnect settings Nov 8, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 6, 2022
@github-actions github-actions bot closed this Feb 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants