Add additional comfoconnect settings#55652
Closed
michaelarnauts wants to merge 11 commits intohome-assistant:devfrom
Closed
Add additional comfoconnect settings#55652michaelarnauts wants to merge 11 commits intohome-assistant:devfrom
michaelarnauts wants to merge 11 commits intohome-assistant:devfrom
Conversation
22 tasks
5086a7a to
cf0c925
Compare
cf0c925 to
f13b1d7
Compare
f13b1d7 to
956b31b
Compare
Contributor
Author
|
@switschel can you try this branch? There was an issue previously that might explain your issues. |
|
@michaelarnauts: I'm disparately waiting for this branch to be merged into HA ;-) Any idea when you plan to change the status of this PR so it can be eventually merged? |
Contributor
Author
|
Sorry, I need to rewrite this so it exposes the preset mode as a separate switch as is explained here: https://developers.home-assistant.io/docs/core/entity/fan#preset-modes |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds
preset_modeto the comfoconnect fan to switch between manual and auto mode.In auto mode, the ventilation will change speed automatically, in manual mode, it will stick to the picked speed. It is still possible to change the speed when in auto mode, but it will fall back after two hours.
This has always been the way it worked, except that the mode wasn't visible or changeable in Home Assistant, so the behaviour depended on the mode that was configured in the Comfoconnect app.
Depends on #54066 to be merged first.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: