Skip to content

Re-add state_class total to sensor#55103

Merged
emontnemery merged 4 commits into
home-assistant:devfrom
emontnemery:resurrect_state_class_total
Sep 6, 2021
Merged

Re-add state_class total to sensor#55103
emontnemery merged 4 commits into
home-assistant:devfrom
emontnemery:resurrect_state_class_total

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Aug 23, 2021

Proposed change

Re-add state_class total to sensor
Driver: Make it possible to support net energy sensors etc.

See also #55136 which adds the last_reset property back to SensorEntity

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (history) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery emontnemery requested a review from a team as a code owner August 23, 2021 20:33
@emontnemery emontnemery marked this pull request as draft August 24, 2021 07:44
@emontnemery emontnemery force-pushed the resurrect_state_class_total branch from 8305430 to cde66b0 Compare August 24, 2021 15:14
@emontnemery emontnemery force-pushed the resurrect_state_class_total branch from cde66b0 to 0f3ce55 Compare September 3, 2021 11:24
@emontnemery emontnemery marked this pull request as ready for review September 3, 2021 11:25
}
DEFAULT_STATISTICS = {
STATE_CLASS_MEASUREMENT: {"mean", "min", "max"},
STATE_CLASS_TOTAL: {"sum"},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is the idea for now to just keep track of sum and not do the increasing/decreasing part yet ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have an implementation of it ready, but I think it makes sense to add that in a follow-up PR.

@emontnemery emontnemery merged commit b99a22c into home-assistant:dev Sep 6, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants