Re-add state_class total to sensor#55103
Merged
emontnemery merged 4 commits intoSep 6, 2021
Merged
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
8305430 to
cde66b0
Compare
22 tasks
cde66b0 to
0f3ce55
Compare
balloob
reviewed
Sep 4, 2021
| } | ||
| DEFAULT_STATISTICS = { | ||
| STATE_CLASS_MEASUREMENT: {"mean", "min", "max"}, | ||
| STATE_CLASS_TOTAL: {"sum"}, |
Member
There was a problem hiding this comment.
So is the idea for now to just keep track of sum and not do the increasing/decreasing part yet ?
Contributor
Author
There was a problem hiding this comment.
Yeah, I have an implementation of it ready, but I think it makes sense to add that in a follow-up PR.
balloob
approved these changes
Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Re-add state_class
totalto sensorDriver: Make it possible to support net energy sensors etc.
See also #55136 which adds the
last_resetproperty back toSensorEntityType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: