Skip to content

Remove last_reset attribute and set state class to total_increasing for mysensors energy sensors #54827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 2 commits into from
Aug 18, 2021
Merged

Remove last_reset attribute and set state class to total_increasing for mysensors energy sensors #54827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f63472
Remove last_reset attribute from mysensors energy sensors
emontnemery Aug 18, 2021
c902277
Adjust tests
emontnemery Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions homeassistant/components/mysensors/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from homeassistant.components.sensor import (
DOMAIN,
STATE_CLASS_MEASUREMENT,
STATE_CLASS_TOTAL_INCREASING,
SensorEntity,
SensorEntityDescription,
)
Expand Down Expand Up @@ -42,7 +43,6 @@
from homeassistant.core import HomeAssistant
from homeassistant.helpers.dispatcher import async_dispatcher_connect
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.util.dt import utc_from_timestamp

from .const import MYSENSORS_DISCOVERY, DiscoveryInfo
from .helpers import on_unload
Expand Down Expand Up @@ -122,8 +122,7 @@
key="V_KWH",
native_unit_of_measurement=ENERGY_KILO_WATT_HOUR,
device_class=DEVICE_CLASS_ENERGY,
state_class=STATE_CLASS_MEASUREMENT,
last_reset=utc_from_timestamp(0),
state_class=STATE_CLASS_TOTAL_INCREASING,
),
"V_LIGHT_LEVEL": SensorEntityDescription(
key="V_LIGHT_LEVEL",
Expand Down
5 changes: 2 additions & 3 deletions tests/components/mysensors/test_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
ATTR_LAST_RESET,
ATTR_STATE_CLASS,
STATE_CLASS_MEASUREMENT,
STATE_CLASS_TOTAL_INCREASING,
)
from homeassistant.const import (
ATTR_DEVICE_CLASS,
Expand All @@ -24,7 +25,6 @@
TEMP_FAHRENHEIT,
)
from homeassistant.core import HomeAssistant
from homeassistant.util.dt import utc_from_timestamp
from homeassistant.util.unit_system import IMPERIAL_SYSTEM, METRIC_SYSTEM, UnitSystem

from tests.common import MockConfigEntry
Expand Down Expand Up @@ -92,8 +92,7 @@ async def test_energy_sensor(
assert state.state == "18000"
assert state.attributes[ATTR_DEVICE_CLASS] == DEVICE_CLASS_ENERGY
assert state.attributes[ATTR_UNIT_OF_MEASUREMENT] == ENERGY_KILO_WATT_HOUR
assert state.attributes[ATTR_STATE_CLASS] == STATE_CLASS_MEASUREMENT
assert state.attributes[ATTR_LAST_RESET] == utc_from_timestamp(0).isoformat()
assert state.attributes[ATTR_STATE_CLASS] == STATE_CLASS_TOTAL_INCREASING


async def test_sound_sensor(
Expand Down