Skip to content

Remove last_reset attribute and set state class to total_increasing for sense energy sensors #54825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Aug 18, 2021
Merged

Remove last_reset attribute and set state class to total_increasing for sense energy sensors #54825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions homeassistant/components/sense/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
"""Support for monitoring a Sense energy sensor."""
import datetime

from homeassistant.components.sensor import STATE_CLASS_MEASUREMENT, SensorEntity
from homeassistant.components.sensor import (
STATE_CLASS_MEASUREMENT,
STATE_CLASS_TOTAL_INCREASING,
SensorEntity,
)
from homeassistant.const import (
ATTR_ATTRIBUTION,
DEVICE_CLASS_ENERGY,
Expand All @@ -12,7 +14,6 @@
)
from homeassistant.core import callback
from homeassistant.helpers.dispatcher import async_dispatcher_connect
import homeassistant.util.dt as dt_util

from .const import (
ACTIVE_NAME,
Expand Down Expand Up @@ -223,7 +224,7 @@ class SenseTrendsSensor(SensorEntity):
"""Implementation of a Sense energy sensor."""

_attr_device_class = DEVICE_CLASS_ENERGY
_attr_state_class = STATE_CLASS_MEASUREMENT
_attr_state_class = STATE_CLASS_TOTAL_INCREASING
_attr_native_unit_of_measurement = ENERGY_KILO_WATT_HOUR
_attr_extra_state_attributes = {ATTR_ATTRIBUTION: ATTRIBUTION}
_attr_icon = ICON
Expand Down Expand Up @@ -258,13 +259,6 @@ def available(self):
"""Return if entity is available."""
return self._had_any_update and self._coordinator.last_update_success

@property
def last_reset(self) -> datetime.datetime:
"""Return the time when the sensor was last reset, if any."""
if self._sensor_type == "DAY":
return dt_util.start_of_local_day()
return None

@callback
def _async_update(self):
"""Track if we had an update so we do not report zero data."""
Expand Down