Remove last_reset attribute and set state class to total_increasing for wemo energy sensors#54821
Conversation
|
Hey there @esev, mind taking a look at this pull request as it has been labeled with an integration ( |
|
@esev I'm a bit perplexed by the unit conversion for the energy sensor, is the sensor's native unit |
frenck
left a comment
There was a problem hiding this comment.
The change itself looks good (besides the above question)
Yes, that is correct. Just double-checked since this logic predates when I became involved with the project. According to one of my Wemo Insights, a computer that uses an average of about about 135 watts consumed 0.47 kWh over 3.5 hours. So it does seem to confirm that the conversion is correct and the device is reporting in mWs. |
Proposed change
Remove
last_resetattribute from and set state class tototal_increasingfor wemo energy sensorsBackground: #54755
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: