Skip to content

Remove last_reset attribute and set state class to total_increasing for wemo energy sensors#54821

Merged
emontnemery merged 1 commit intohome-assistant:devfrom
emontnemery:wemo_remove_last_reset
Aug 18, 2021
Merged

Remove last_reset attribute and set state class to total_increasing for wemo energy sensors#54821
emontnemery merged 1 commit intohome-assistant:devfrom
emontnemery:wemo_remove_last_reset

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Aug 18, 2021

Proposed change

Remove last_reset attribute from and set state class to total_increasing for wemo energy sensors

Background: #54755

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @esev, mind taking a look at this pull request as it has been labeled with an integration (wemo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery
Copy link
Copy Markdown
Contributor Author

@esev I'm a bit perplexed by the unit conversion for the energy sensor, is the sensor's native unit mWs (milliwatt-second)?

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good (besides the above question)

@frenck frenck added the energy Related to energy management label Aug 18, 2021
@esev
Copy link
Copy Markdown
Contributor

esev commented Aug 18, 2021

@esev I'm a bit perplexed by the unit conversion for the energy sensor, is the sensor's native unit mWs (milliwatt-second)?

Yes, that is correct. Just double-checked since this logic predates when I became involved with the project. According to one of my Wemo Insights, a computer that uses an average of about about 135 watts consumed 0.47 kWh over 3.5 hours. So it does seem to confirm that the conversion is correct and the device is reporting in mWs.

@emontnemery emontnemery merged commit 6eba04c into home-assistant:dev Aug 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed energy Related to energy management integration: wemo small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants