Skip to content

Remove last_reset attribute and set state class to total_increasing for kostal_plenticore energy sensors #54817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emontnemery merged 1 commit into from
Aug 18, 2021
Merged

Remove last_reset attribute and set state class to total_increasing for kostal_plenticore energy sensors #54817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions homeassistant/components/kostal_plenticore/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
"""Constants for the Kostal Plenticore Solar Inverter integration."""

from homeassistant.components.sensor import (
ATTR_LAST_RESET,
ATTR_STATE_CLASS,
STATE_CLASS_MEASUREMENT,
STATE_CLASS_TOTAL_INCREASING,
)
from homeassistant.const import (
ATTR_DEVICE_CLASS,
Expand Down Expand Up @@ -304,8 +304,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down Expand Up @@ -346,8 +345,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down Expand Up @@ -388,8 +386,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down Expand Up @@ -430,8 +427,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down Expand Up @@ -472,8 +468,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down Expand Up @@ -514,8 +509,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down Expand Up @@ -556,8 +550,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down Expand Up @@ -599,8 +592,7 @@
{
ATTR_UNIT_OF_MEASUREMENT: ENERGY_KILO_WATT_HOUR,
ATTR_DEVICE_CLASS: DEVICE_CLASS_ENERGY,
ATTR_STATE_CLASS: STATE_CLASS_MEASUREMENT,
ATTR_LAST_RESET: LAST_RESET_NEVER,
ATTR_STATE_CLASS: STATE_CLASS_TOTAL_INCREASING,
},
"format_energy",
),
Expand Down
13 changes: 2 additions & 11 deletions homeassistant/components/kostal_plenticore/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
"""Platform for Kostal Plenticore sensors."""
from __future__ import annotations

from datetime import datetime, timedelta
from datetime import timedelta
import logging
from typing import Any, Callable

from homeassistant.components.sensor import (
ATTR_LAST_RESET,
ATTR_STATE_CLASS,
SensorEntity,
)
from homeassistant.components.sensor import ATTR_STATE_CLASS, SensorEntity
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import ATTR_DEVICE_CLASS, ATTR_ICON, ATTR_UNIT_OF_MEASUREMENT
from homeassistant.core import HomeAssistant
Expand Down Expand Up @@ -193,11 +189,6 @@ def entity_registry_enabled_default(self) -> bool:
"""Return if the entity should be enabled when first added to the entity registry."""
return self._sensor_data.get(ATTR_ENABLED_DEFAULT, False)

@property
def last_reset(self) -> datetime | None:
"""Return the last_reset time."""
return self._sensor_data.get(ATTR_LAST_RESET)

@property
def native_value(self) -> Any | None:
"""Return the state of the sensor."""
Expand Down