Skip to content

Remove last_reset attribute from fritz sensors #54806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Aug 18, 2021
Merged

Remove last_reset attribute from fritz sensors #54806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions homeassistant/components/fritz/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@
from fritzconnection.core.exceptions import FritzConnectionException
from fritzconnection.lib.fritzstatus import FritzStatus

from homeassistant.components.sensor import STATE_CLASS_MEASUREMENT, SensorEntity
from homeassistant.components.sensor import (
STATE_CLASS_MEASUREMENT,
STATE_CLASS_TOTAL_INCREASING,
SensorEntity,
)
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import (
DATA_GIGABYTES,
Expand Down Expand Up @@ -134,7 +138,6 @@ class SensorData(TypedDict, total=False):
name: str
device_class: str | None
state_class: str | None
last_reset: bool
unit_of_measurement: str | None
icon: str | None
state_provider: Callable
Expand Down Expand Up @@ -185,16 +188,14 @@ class SensorData(TypedDict, total=False):
),
"gb_sent": SensorData(
name="GB sent",
state_class=STATE_CLASS_MEASUREMENT,
last_reset=True,
state_class=STATE_CLASS_TOTAL_INCREASING,
unit_of_measurement=DATA_GIGABYTES,
icon="mdi:upload",
state_provider=_retrieve_gb_sent_state,
),
"gb_received": SensorData(
name="GB received",
state_class=STATE_CLASS_MEASUREMENT,
last_reset=True,
state_class=STATE_CLASS_TOTAL_INCREASING,
unit_of_measurement=DATA_GIGABYTES,
icon="mdi:download",
state_provider=_retrieve_gb_received_state,
Expand Down Expand Up @@ -284,7 +285,6 @@ def __init__(
"""Init FRITZ!Box connectivity class."""
self._sensor_data: SensorData = SENSOR_DATA[sensor_type]
self._last_device_value: str | None = None
self._last_wan_value: str | None = None
self._attr_available = True
self._attr_device_class = self._sensor_data.get("device_class")
self._attr_icon = self._sensor_data.get("icon")
Expand Down Expand Up @@ -316,12 +316,3 @@ def update(self) -> None:
self._attr_native_value = self._last_device_value = self._state_provider(
status, self._last_device_value
)

if self._sensor_data.get("last_reset") is True:
self._last_wan_value = _retrieve_connection_uptime_state(
status, self._last_wan_value
)
self._attr_last_reset = datetime.datetime.strptime(
self._last_wan_value,
"%Y-%m-%dT%H:%M:%S%z",
)