Remove last_reset attribute and set state class to total_increasing for tibber energy sensors#54799
Merged
Danielhiversen merged 4 commits intohome-assistant:devfrom Aug 18, 2021
Conversation
probot-home-assistant
bot
added
integration: tibber
small-pr
|
Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration ( |
Danielhiversen
requested changes
Aug 18, 2021
| native_unit_of_measurement=ENERGY_KILO_WATT_HOUR, | ||
| state_class=STATE_CLASS_MEASUREMENT, | ||
| state_class=STATE_CLASS_TOTAL_INCREASING, | ||
| reset_type=ResetType.DAILY, |
Member
There was a problem hiding this comment.
reset_type should not be needed anymore
Member
|
Fixed a merge conflict |
frenck
added
energy
frenck
requested changes
Aug 18, 2021
frenck
removed
the
smash
Co-authored-by: Franck Nijhof <git@frenck.dev>
Danielhiversen
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove
last_resetattribute and set state class tototal_increasingfor tibber energy sensorsBackground: #54755
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: