Add RESOLUTION attribute to EXT-X-STREAM-INF#54667
Add RESOLUTION attribute to EXT-X-STREAM-INF#54667allenporter wants to merge 1 commit intohome-assistant:devfrom
Conversation
|
Hey there @hunterjm, @uvjustin, mind taking a look at this pull request as it has been labeled with an integration ( |
|
The master playlist was only added for casting (#40483) and the frontend actually ends up parsing the master playlist and only passing the regular playlist on to the actual video players (see home-assistant/frontend#7417) i.e. the master playlist is only used internally except for on cast devices. I'm thinking it might not be worth it trying to fix all the |
Sounds good, thanks. |
Breaking change
Proposed change
Add the RESOLUTION attribute to the EXT-X-STREAM-INF tag to address a
Must Fix Issuefrom Apple's Media Stream Validator & HLS Report.The
Must Fix Issuecited the message:Your EXT-X-STREAM-INF and EXT-X-I-FRAME-STREAM-INF tags MUST always provide the RESOLUTION attribute if the rendition(s) include video.The resolution is a property of the input stream, so this introduces a new way for the stream worker to pass information to the
StreamOutput. The worker does not currently have a great way to track stream output additional/removals so it currently just sets this property every segment anyway for now. Assuming we may have other properties like this in the future, so made this choice rather than just attaching more data to everySegment-- but open to other suggestions.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: