Skip to content

Add RESOLUTION attribute to EXT-X-STREAM-INF#54667

Closed
allenporter wants to merge 1 commit intohome-assistant:devfrom
allenporter:stream-validator
Closed

Add RESOLUTION attribute to EXT-X-STREAM-INF#54667
allenporter wants to merge 1 commit intohome-assistant:devfrom
allenporter:stream-validator

Conversation

@allenporter
Copy link
Contributor

Breaking change

Proposed change

Add the RESOLUTION attribute to the EXT-X-STREAM-INF tag to address a Must Fix Issue from Apple's Media Stream Validator & HLS Report.

The Must Fix Issue cited the message: Your EXT-X-STREAM-INF and EXT-X-I-FRAME-STREAM-INF tags MUST always provide the RESOLUTION attribute if the rendition(s) include video.

The resolution is a property of the input stream, so this introduces a new way for the stream worker to pass information to the StreamOutput . The worker does not currently have a great way to track stream output additional/removals so it currently just sets this property every segment anyway for now. Assuming we may have other properties like this in the future, so made this choice rather than just attaching more data to every Segment -- but open to other suggestions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @hunterjm, @uvjustin, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@uvjustin
Copy link
Contributor

The master playlist was only added for casting (#40483) and the frontend actually ends up parsing the master playlist and only passing the regular playlist on to the actual video players (see home-assistant/frontend#7417) i.e. the master playlist is only used internally except for on cast devices. I'm thinking it might not be worth it trying to fix all the Must Fix Issues in the the master playlist unless we really suspect it is the cause of a problem.

@allenporter
Copy link
Contributor Author

The master playlist was only added for casting (#40483) and the frontend actually ends up parsing the master playlist and only passing the regular playlist on to the actual video players (see home-assistant/frontend#7417) i.e. the master playlist is only used internally except for on cast devices. I'm thinking it might not be worth it trying to fix all the Must Fix Issues in the the master playlist unless we really suspect it is the cause of a problem.

Sounds good, thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2021
@allenporter allenporter deleted the stream-validator branch November 14, 2021 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants