Update Zwave js to use state class total increasing#54600
Update Zwave js to use state class total increasing#54600Danielhiversen wants to merge 3 commits intodevfrom
Conversation
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( |
raman325
left a comment
There was a problem hiding this comment.
We should also get rid of the logic in async_added_to_hass that sets up a listener for last reset along with the dispatcher in the meter_reset service since we no longer need to set last reset
|
So we will remove SERVICE_RESET_METER? |
We should keep the service, but there is logic in there to dispatch a signal every time the service is called so that the listener we set up in |
|
I guess what I am not clear on is for meters that aren't in the energy device class, should we still track last reset or not? The PR implies we don't want to track last reset at all, in which case we should remove this logic entirely: https://github.com/home-assistant/core/blob/dev/homeassistant/components/zwave_js/sensor.py#L254-L294 Remove the RestoreEntity as a mixin, and remove https://github.com/home-assistant/core/blob/dev/homeassistant/components/zwave_js/sensor.py#L318-L325 |
Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
Breaking change
Proposed change
Update Zwave js to use state class total increasing and total
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: