Skip to content

Add energy validation#54567

Merged
balloob merged 9 commits intodevfrom
validate-energy-preferences
Aug 18, 2021
Merged

Add energy validation#54567
balloob merged 9 commits intodevfrom
validate-energy-preferences

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Aug 12, 2021

Breaking change

Proposed change

Add a validate command to the energy WS API so that we can show errors/warnings in the energy dashboard if we detect incorrect data. Ie we catch negative meters etc.

Things not added in this PR but we can add in the future:

  • Notify if stat has no data but should come in the future

Requires home-assistant/frontend#9802

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (energy) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob force-pushed the validate-energy-preferences branch from 47f45a2 to 08b0cc8 Compare August 13, 2021 18:17
@frenck frenck added energy Related to energy management smash Indicator this PR is close to finish for merging or closing labels Aug 16, 2021
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Aug 18, 2021

This PR already includes validation to ensure #54755 works. This means that tests will fail now beceause it detects the cost sensors as invalid. Rebase once it's merged and tests pass.

@balloob balloob force-pushed the validate-energy-preferences branch from 165146d to 97ba7b9 Compare August 18, 2021 15:51
@balloob balloob merged commit 2f77b50 into dev Aug 18, 2021
@balloob balloob deleted the validate-energy-preferences branch August 18, 2021 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core energy Related to energy management has-tests integration: energy integration: recorder smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants