-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuya v2 integration New Update #53510
Conversation
Hey there @ollo69, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please limit the initial PR to a single platform, following:
A PR this size cannot be reviewed correctly.
…ouldn't add one for the v2 and mark it as deprecated, just drop it
project_type = ProjectType(user_input[CONF_PROJECT_TYPE]) | ||
api = TuyaOpenAPI( | ||
user_input[CONF_ENDPOINT] | ||
if project_type == ProjectType.INDUSTY_SOLUTIONS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to bump the library version where the typo in ProjectType.INDUSTY_SOLUTIONS
is addressed in a separate new PR after this PR is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have recorded this
Besides the comments above, please check the CI build errors and address those too. Almost ready now. 👍 |
unit test optimization and crash protection
ci build errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A final comment above and then this is good to go. 👍
code review
Done, thanks for the comment, please help to review and merge the PR. |
Thanks! |
Breaking change
Tuya Smart always strive to provide the best development experience possible and keep updating our Home Assistant integration capabilities. Since the old version of Tuya Home Assistant integration supports limited categories and control commands, now we bring you our new integration with extended support for more categories and commands.
Our new integration is built on Tuya’s standard Open APIs and tackles the limits of categories and accessible control commands. We deliver more development-friendly features including virtual device debugging, official authorization, and technical supports, which will help you efficiently work on development with the Tuya ecosystem.
The existing Tuya Integration is no longer maintained by Tuya officially, and will be deprecated. The estimated deprecation date is 2021.12.31. The new integration will be officially maintained by the Tuya Developer Team, for more information of the migration, please check this documentation How to Migrate the Tuya Home Assistant Integration from the Old Version
Users must login again to use the updated Tuya integration.
Proposed change
As we discussed with Paulus previously, it's the minimum viable integration that allows it to be configured via a config flow. Include a small integration to make sure it all works.
Supported Device Category
Support Scene feature
Support new device pairing status refresh
Support Tuya smart home cloud project type
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: