[recorder] Include & Exclude domain fix & unit tests#5213
Merged
Conversation
houndci-bot
reviewed
Jan 7, 2017
kellerza
force-pushed
the
recorder_test
branch
from
e5550f2 to
9b9bec8
Compare
balloob
reviewed
Jan 8, 2017
|
|
||
| entity_id = event.data.get(ATTR_ENTITY_ID) | ||
| domain = event.data.get(ATTR_DOMAIN) | ||
| entity_id = str(event.data.get(ATTR_ENTITY_ID)) |
Member
There was a problem hiding this comment.
This is always a string? If not, we should error out instead of trying to "fix" it because it means malformed state changed events are being sent.
Member
Author
There was a problem hiding this comment.
👍 Events that are not STATE_CHANGE dont have entity_ids.
New commit should handle this better
Maxr1998
approved these changes
Jan 8, 2017
|
Looking good! |
pvizeli
approved these changes
Jan 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Unit tests for include & exclude
Related issue (if applicable): fixes #4733
Example entry for
configuration.yaml(if applicable):Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass