Convert ecobee pressure to local units#51379
Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom Jun 9, 2021
Merged
Convert ecobee pressure to local units#51379MartinHjelmare merged 2 commits intohome-assistant:devfrom
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Conversation
bjpetit
suggested changes
Jun 9, 2021
thomasgermain
pushed a commit
to thomasgermain/home-assistant
that referenced
this pull request
Jun 10, 2021
* Convert ecobee pressure to local units * Round inHg to 2 places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Convert the pressure in the Ecobee weather integration to metric/imperial depending on what Home Assistant is configured to use. This is the same behavior as the OpenWeatherMap (code) and Climacell (code) weather integrations.
The pressure units from Ecobee API are undocumented, but they look like hPa or millibars (both are equal so I just chose hPa in the code). See #24524 as well.
Type of change
Additional information
weatherintegrations that do not convert their pressure units to the correct format. There is probably a better solution than making each integration convert to the correct pressure unit: Something like #48641 seems like it could help.Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: