Skip to content

Update sia tests#51151

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
eavanvalkenburg:sia_tests
May 27, 2021
Merged

Update sia tests#51151
MartinHjelmare merged 1 commit intohome-assistant:devfrom
eavanvalkenburg:sia_tests

Conversation

@eavanvalkenburg
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Type of change

updates in the tests for the SIA integration.

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@eavanvalkenburg
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare updates to the tests from #36625

@MartinHjelmare MartinHjelmare changed the title Updated tests for sia Update sia tests May 27, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 701c4ee into home-assistant:dev May 27, 2021
@eavanvalkenburg eavanvalkenburg deleted the sia_tests branch May 28, 2021 06:16
eavanvalkenburg added a commit to eavanvalkenburg/home-assistant that referenced this pull request May 28, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants