Skip to content

Add refresh when changing SmartTub filtration settings#51014

Merged
bdraco merged 1 commit intohome-assistant:devfrom
mdz:smarttub-reminder-refresh
May 24, 2021
Merged

Add refresh when changing SmartTub filtration settings#51014
bdraco merged 1 commit intohome-assistant:devfrom
mdz:smarttub-reminder-refresh

Conversation

@mdz
Copy link
Copy Markdown
Contributor

@mdz mdz commented May 23, 2021

Proposed change

Poll the API immediately after changing the settings so that the state refreshes quickly in hass

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added integration: smarttub small-pr PRs with less than 30 lines. labels May 23, 2021
@mdz mdz changed the title add missing refresh when changing filtration settings Add refresh when changing SmartTub filtration settings May 23, 2021
@bdraco bdraco merged commit d7da32c into home-assistant:dev May 24, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants