Skip to content

Allow manual scan and add delay in modbus switch verify#50974

Merged
janiversen merged 1 commit into
home-assistant:devfrom
janiversen:switch_verify_delay
May 24, 2021
Merged

Allow manual scan and add delay in modbus switch verify#50974
janiversen merged 1 commit into
home-assistant:devfrom
janiversen:switch_verify_delay

Conversation

@janiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

setting scan_interval: 0, disables the timer, and thus there are no polling. This feature is useful for switches, where there are no physical contact and therefore no reason to poll.

Add new parameter:

modbus:
    ...
    switches:
        - name: test1
           verify:
              delay: 10

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@janiversen
Copy link
Copy Markdown
Member Author

@thehaxxa this one is for you.

@janiversen
Copy link
Copy Markdown
Member Author

@MartinHjelmare thanks for reviewing my 2 other PRs, the change in this PR is more important since 2021.6 is cut this Wednesday and this is a schema change.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@janiversen janiversen merged commit be13a73 into home-assistant:dev May 24, 2021
@janiversen janiversen deleted the switch_verify_delay branch May 24, 2021 11:00
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants