Skip to content

Add restore temperature to modbus climate#50963

Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom
janiversen:climate
May 24, 2021
Merged

Add restore temperature to modbus climate#50963
MartinHjelmare merged 3 commits intohome-assistant:devfrom
janiversen:climate

Conversation

@janiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Try to restore target_temperature in climate, unfortunately the climateEntity, do not store all temperatures, so it needs a little bit of coding.

With this PR all modbus platform have restore_last_state active.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as its been labeled with an integration (modbus) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@KapJI
Copy link
Copy Markdown
Member

KapJI commented May 22, 2021

Mypy failure fixed by #50965

@janiversen
Copy link
Copy Markdown
Member Author

Mypy failure fixed by #50965

thanks.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 1546dbb into home-assistant:dev May 24, 2021
@janiversen janiversen deleted the climate branch May 24, 2021 12:07
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants