Skip to content

Define binary_sensor entity attribute as class variables#50940

Merged
balloob merged 1 commit intodevfrom
frenck-2021-1582
May 22, 2021
Merged

Define binary_sensor entity attribute as class variables#50940
balloob merged 1 commit intodevfrom
frenck-2021-1582

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 21, 2021

Proposed change

Defines BinarySensorEntity entity attributes as class variables,
followup of the implementation started in #50925

For full context #50925 is the best place to take a look.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label May 21, 2021
@frenck frenck marked this pull request as ready for review May 22, 2021 16:17
@frenck
Copy link
Copy Markdown
Member Author

frenck commented May 22, 2021

Parent merged, marked ready for review.

@balloob balloob merged commit d3bc2bc into dev May 22, 2021
@balloob balloob deleted the frenck-2021-1582 branch May 22, 2021 16:20
def is_on(self):
def is_on(self) -> bool | None:
"""Return true if the binary sensor is on."""
return None
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_attr_is_on is not used.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, opening a fix for that 👍 (after CI has been fixed)

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants