Skip to content

Mark battery, humidity and pressure sensors as STATE_CLASS_MEASUREMENT#50924

Merged
emontnemery merged 2 commits intohome-assistant:devfrom
emontnemery:battery_humidity_pressure_sensor_state_class_top50
May 24, 2021
Merged

Mark battery, humidity and pressure sensors as STATE_CLASS_MEASUREMENT#50924
emontnemery merged 2 commits intohome-assistant:devfrom
emontnemery:battery_humidity_pressure_sensor_state_class_top50

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Mark battery, humidity and pressure sensors from top 50 integrations as STATE_CLASS_MEASUREMENT

Note: Openweathermap is intentionally omitted

Background:

  • To be included in long term statistics collection, sensors should set its state_class property to STATE_CLASS_MEASUREMENT. Exceptions are sensors which expose some historic data (e.g. yesterday's high) or future prediction (e.g. a weather forecast)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Kane610, mind taking a look at this pull request as its been labeled with an integration (deconz) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deCONZ has a battery sensor defined on line 262 of deconz/sensor.py

Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zha looks good

@emontnemery emontnemery force-pushed the battery_humidity_pressure_sensor_state_class_top50 branch from dd92426 to e09b429 Compare May 24, 2021 08:36
@emontnemery
Copy link
Copy Markdown
Contributor Author

@Kane610 fixed in e09b429

Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for deconz

@emontnemery emontnemery merged commit b169a8d into home-assistant:dev May 24, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.