Improve legacy support for Hunter Douglas PowerView#50918
Merged
bdraco merged 6 commits intohome-assistant:devfrom May 23, 2021
Merged
Improve legacy support for Hunter Douglas PowerView#50918bdraco merged 6 commits intohome-assistant:devfrom
bdraco merged 6 commits intohome-assistant:devfrom
Conversation
Contributor
|
Hi @HighOnMikey, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
HighOnMikey
force-pushed
the
hunter-douglas-additional-legacy-support
branch
from
367a581 to
7a87791
Compare
bdraco
reviewed
May 23, 2021
| if not fwversion: | ||
| fwversion = json.loads(load_fixture("hunterdouglas_powerview/fwversion.json")) | ||
| if get_resources: | ||
| type(mock_powerview_fwversion).get_resources = AsyncMock( |
Member
There was a problem hiding this comment.
We don't need the type() wrapping anymore
Member
|
This looks good. I'm going to test it on a v2 hub to make sure it doesn't break anything. |
bdraco
reviewed
May 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Reorganize the logic that determines device models and firmware versions to improve support for legacy hubs. This should help keep better track of device capability since legacy hubs have slightly reduced functionality compared to the latest hubs.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: