Skip to content

Fix coinbase response pagination#50890

Merged
Danielhiversen merged 2 commits intohome-assistant:devfrom
renaiku:fix_50500
May 22, 2021
Merged

Fix coinbase response pagination#50890
Danielhiversen merged 2 commits intohome-assistant:devfrom
renaiku:fix_50500

Conversation

@renaiku
Copy link
Copy Markdown
Contributor

@renaiku renaiku commented May 20, 2021

Proposed change

This PR fixes #50500
Coinbase's API evolved and the integration needed a small refreshing.
(the API is now giving paginated results, that's why nobody could see their complete wallet)
This fix doesn't change end user config file.
It should work out of the box

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @renaiku,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Fix issue #50500 Fix coinbase response pagination May 20, 2021
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Danielhiversen Danielhiversen merged commit 99e58f3 into home-assistant:dev May 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coinbase no longer loads sensors after update to 2021.4

4 participants