Skip to content

Sonos use common firmware version#50861

Merged
bdraco merged 2 commits intohome-assistant:devfrom
jjlawren:sonos_use_common_firmware_version
May 23, 2021
Merged

Sonos use common firmware version#50861
bdraco merged 2 commits intohome-assistant:devfrom
jjlawren:sonos_use_common_firmware_version

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

Breaking change

The device associated with Sonos speakers will report a different firmware version, switching to the more common version.

Proposed change

This changes from an internal version to the one that's user-facing everywhere else.

Example from speaker:

>>> s.get_speaker_info()
{'zone_name': 'The Moon', 'player_icon': '/img/icon-S12.png', 'uid': 'RINCON_AABBCCDDEEFF1400', 'serial_number': 'AA-BB-CC-DD-EE-FF:2', 'software_version': '63.2-88230', 'hardware_version': '1.20.1.6-1.1', 'model_number': 'S12', 'model_name': 'Sonos Play:1', 'display_version': '13.1', 'mac_address': 'AA-BB-CC-DD-EE-FF'}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @cgtobi, mind taking a look at this pull request as its been labeled with an integration (sonos) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdraco bdraco merged commit 29205a9 into home-assistant:dev May 23, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2021
@jjlawren jjlawren deleted the sonos_use_common_firmware_version branch May 31, 2022 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants