Skip to content

Upgrade pylint to 2.8.2#50669

Merged
frenck merged 1 commit intodevfrom
frenck-2021-1508
May 15, 2021
Merged

Upgrade pylint to 2.8.2#50669
frenck merged 1 commit intodevfrom
frenck-2021-1508

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 15, 2021

Proposed change

Upgrades pylint to 2.8.2.

Introduces 1 false positive, which has been flagged to ignore.

Additionally, removed the dependency to astroid. This was introduced a long time ago to work around an issue, however, that isn't an problem anymore. Pylint now has the latest version of astroid already pinned.

Release notes:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added dependency Pull requests marked as a dependency upgrade integration: sentry small-pr PRs with less than 30 lines. by-code-owner labels May 15, 2021
@probot-home-assistant
Copy link
Copy Markdown

Hey there @dcramer, mind taking a look at this pull request as its been labeled with an integration (sentry) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck merged commit de77e0b into dev May 15, 2021
@frenck frenck deleted the frenck-2021-1508 branch May 15, 2021 17:41
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: sentry small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants