Skip to content

Add targets and selectors for services (X-Z)#50639

Merged
cgarwood merged 2 commits intohome-assistant:devfrom
tkdrob:Add-targets-and-selectors-for-services-(X-Z)
May 15, 2021
Merged

Add targets and selectors for services (X-Z)#50639
cgarwood merged 2 commits intohome-assistant:devfrom
tkdrob:Add-targets-and-selectors-for-services-(X-Z)

Conversation

@tkdrob
Copy link
Copy Markdown
Contributor

@tkdrob tkdrob commented May 15, 2021

Breaking change

Proposed change

Add targets and selectors for services (X-Z)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Danielhiversen, @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_aqara) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (zone) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/xiaomi_miio/services.yaml Outdated
Comment thread homeassistant/components/yeelight/services.yaml Outdated
Comment thread homeassistant/components/yeelight/services.yaml Outdated
Copy link
Copy Markdown
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be good, to add units to the brightness value and also set it as slider

Comment thread homeassistant/components/yeelight/services.yaml
Comment thread homeassistant/components/yeelight/services.yaml
Comment thread homeassistant/components/yeelight/services.yaml Outdated
Comment thread homeassistant/components/yeelight/services.yaml
Comment thread homeassistant/components/yeelight/services.yaml Outdated
Comment thread homeassistant/components/yeelight/services.yaml
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tkdrob 👍

Great job on getting this all done! 🎉

../Frenck 🚂

@cgarwood cgarwood merged commit 7b5fff3 into home-assistant:dev May 15, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2021
@tkdrob tkdrob deleted the Add-targets-and-selectors-for-services-(X-Z) branch August 23, 2021 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants