Add targets and selectors for services (X-Z)#50639
Merged
cgarwood merged 2 commits intohome-assistant:devfrom May 15, 2021
Merged
Add targets and selectors for services (X-Z)#50639cgarwood merged 2 commits intohome-assistant:devfrom
cgarwood merged 2 commits intohome-assistant:devfrom
Conversation
|
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
|
Hey there @Danielhiversen, @syssi, mind taking a look at this pull request as its been labeled with an integration ( |
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
frenck
requested changes
May 15, 2021
TheZoker
reviewed
May 15, 2021
Contributor
TheZoker
left a comment
There was a problem hiding this comment.
I guess it would be good, to add units to the brightness value and also set it as slider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add targets and selectors for services (X-Z)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: