Add PV3 / DC3 sensors to Kostal Plenticore#50614
Merged
frenck merged 2 commits intohome-assistant:devfrom May 15, 2021
SaSa1983:dev
Merged
Add PV3 / DC3 sensors to Kostal Plenticore#50614frenck merged 2 commits intohome-assistant:devfrom SaSa1983:dev
frenck merged 2 commits intohome-assistant:devfrom
SaSa1983:dev
Conversation
Contributor
8 tasks
Contributor
Contributor
|
I tested it and it still works as expected for my two solar string setup. The changes seems to be ok for me but some checks are failing (black and flake8). |
Member
|
Ran |
frenck
approved these changes
May 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The current implementation of the Kostal Plenticore integration is missing the PV3/DC3 sensors.
This PR adds them as requested by @stegm in the Feature Reqeust
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: