Skip to content

Add PV3 / DC3 sensors to Kostal Plenticore#50614

Merged
frenck merged 2 commits intohome-assistant:devfrom
SaSa1983:dev
May 15, 2021
Merged

Add PV3 / DC3 sensors to Kostal Plenticore#50614
frenck merged 2 commits intohome-assistant:devfrom
SaSa1983:dev

Conversation

@SaSa1983
Copy link
Copy Markdown
Contributor

@SaSa1983 SaSa1983 commented May 14, 2021

Proposed change

The current implementation of the Kostal Plenticore integration is missing the PV3/DC3 sensors.
This PR adds them as requested by @stegm in the Feature Reqeust

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @SaSa1983,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @stegm, mind taking a look at this pull request as its been labeled with an integration (kostal_plenticore) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@stegm
Copy link
Copy Markdown
Contributor

stegm commented May 14, 2021

Hey there @stegm, mind taking a look at this pull request as its been labeled with an integration (kostal_plenticore) you are listed as a codeowner for? Thanks!

Thanks for preparing the PR. I'll will take a look at it soon.

@stegm
Copy link
Copy Markdown
Contributor

stegm commented May 15, 2021

I tested it and it still works as expected for my two solar string setup. The changes seems to be ok for me but some checks are failing (black and flake8).

@frenck
Copy link
Copy Markdown
Member

frenck commented May 15, 2021

Ran black --fast homeassistant to resolve the CI issue and pushed it into this branch.

@frenck frenck merged commit f142f29 into home-assistant:dev May 15, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants