Skip to content

Add support for Hue push updates#50591

Merged
balloob merged 8 commits intodevfrom
hue-push-updates
May 14, 2021
Merged

Add support for Hue push updates#50591
balloob merged 8 commits intodevfrom
hue-push-updates

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 13, 2021

Breaking change

Proposed change

Add support for Hue push updates.

Changelog aiohue: https://github.com/home-assistant-libs/aiohue/releases/tag/2.4.0

Push updates are currently limited to lights and groups. There is such a thing as a motion event but I don't have a sensor at home to verify. Motion is now added too.

I've added extensive debug logging to aiohue, so if you have sensors, try enabling debug logging and report your findings here home-assistant-libs/aiohue#49

logger:
  default: info
  logs:
    aiohue: debug

TODO:

  • write tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @frenck, mind taking a look at this pull request as its been labeled with an integration (hue) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 14, 2021

Tested, works great 👍

@balloob balloob marked this pull request as ready for review May 14, 2021 04:14
@balloob balloob merged commit 646af53 into dev May 14, 2021
@balloob balloob deleted the hue-push-updates branch May 14, 2021 20:39
@frenck frenck mentioned this pull request May 15, 2021
21 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants