Flic bump lib to 2.0.3#50483
Merged
frenck merged 3 commits intohome-assistant:devfrom May 15, 2021
DavidDeSloovere:flic-bump-lib
Merged
Flic bump lib to 2.0.3#50483frenck merged 3 commits intohome-assistant:devfrom DavidDeSloovere:flic-bump-lib
frenck merged 3 commits intohome-assistant:devfrom
DavidDeSloovere:flic-bump-lib
Conversation
Member
|
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant. Thanks already! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update to latest PyPi package. Is a copy of the official python client from the company behind flic.
Opens up future work for improvements, like reconnecting to flic server, supporting v2 buttons and maybe getting more info from the flic server to store as attributes.
Edit:
Was previously using https://pypi.org/project/pyflic-homeassistant/ which was a package built from https://github.com/soldag/pyflic - soldag has now release it's own package as https://pypi.org/project/pyflic/
New file used in HA is https://github.com/soldag/pyflic/blob/6fde87c0218fa086626ae52fdabf44fff5b569d1/pyflic/__init__.py
Old version was https://github.com/soldag/pyflic/blob/56c46996b9d1cbe267927da01e3e78539197da73/fliclib.py
The pyflic repo is a copy this file (which is not packaged)
https://github.com/50ButtonsEach/fliclib-linux-hci/blob/master/clientlib/python/fliclib.py
Release notes here are empty https://pypi.org/project/pyflic/#history
But soldag used same versions are the original repo, and these are the official release notes https://github.com/50ButtonsEach/fliclib-linux-hci/releases
(I tested the update, my flic button still worked.)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests:
🙈 I wish my Python was that good to review PRs here. But I tried.