Skip to content

Flic bump lib to 2.0.3#50483

Merged
frenck merged 3 commits intohome-assistant:devfrom
DavidDeSloovere:flic-bump-lib
May 15, 2021
Merged

Flic bump lib to 2.0.3#50483
frenck merged 3 commits intohome-assistant:devfrom
DavidDeSloovere:flic-bump-lib

Conversation

@DavidDeSloovere
Copy link
Copy Markdown
Contributor

@DavidDeSloovere DavidDeSloovere commented May 11, 2021

Proposed change

Update to latest PyPi package. Is a copy of the official python client from the company behind flic.
Opens up future work for improvements, like reconnecting to flic server, supporting v2 buttons and maybe getting more info from the flic server to store as attributes.

Edit:
Was previously using https://pypi.org/project/pyflic-homeassistant/ which was a package built from https://github.com/soldag/pyflic - soldag has now release it's own package as https://pypi.org/project/pyflic/

New file used in HA is https://github.com/soldag/pyflic/blob/6fde87c0218fa086626ae52fdabf44fff5b569d1/pyflic/__init__.py
Old version was https://github.com/soldag/pyflic/blob/56c46996b9d1cbe267927da01e3e78539197da73/fliclib.py

The pyflic repo is a copy this file (which is not packaged)
https://github.com/50ButtonsEach/fliclib-linux-hci/blob/master/clientlib/python/fliclib.py

Release notes here are empty https://pypi.org/project/pyflic/#history
But soldag used same versions are the original repo, and these are the official release notes https://github.com/50ButtonsEach/fliclib-linux-hci/releases

(I tested the update, my flic button still worked.)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

🙈 I wish my Python was that good to review PRs here. But I tried.

@probot-home-assistant probot-home-assistant Bot added dependency Pull requests marked as a dependency upgrade integration: flic small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file labels May 11, 2021
@DavidDeSloovere DavidDeSloovere marked this pull request as ready for review May 12, 2021 11:18
@frenck
Copy link
Copy Markdown
Member

frenck commented May 12, 2021

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @DavidDeSloovere 👍

@frenck frenck merged commit bdc1ab2 into home-assistant:dev May 15, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2021
@DavidDeSloovere DavidDeSloovere deleted the flic-bump-lib branch May 18, 2021 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade dependency-bump Pull requests that update a dependency file integration: flic small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants