Skip to content

Fix Netatmo climate#50238

Merged
frenck merged 1 commit intohome-assistant:devfrom
cgtobi:netatmo_climate_fix_50203
May 7, 2021
Merged

Fix Netatmo climate#50238
frenck merged 1 commit intohome-assistant:devfrom
cgtobi:netatmo_climate_fix_50203

Conversation

@cgtobi
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi commented May 7, 2021

Breaking change

Proposed change

Due to changes in the server response from the Netatmo API climate devices were not discovered. This addresses the issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cgtobi cgtobi added this to the 2021.5.1 milestone May 7, 2021
@frenck frenck merged commit 86393bd into home-assistant:dev May 7, 2021
frenck pushed a commit that referenced this pull request May 7, 2021
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Netatmo Stop working with 2021.5

4 participants