Skip to content

Better support for alarm panels in ZHA#50235

Merged
Adminiuga merged 1 commit intohome-assistant:devfrom
dmulcahey:dm/zha-better-alarm-panel-support
May 7, 2021
Merged

Better support for alarm panels in ZHA#50235
Adminiuga merged 1 commit intohome-assistant:devfrom
dmulcahey:dm/zha-better-alarm-panel-support

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

Proposed change

This PR tweaks the initial support for alarm control panels in ZHA. Originally the code was looking for a server IAS Ace cluster on a device only. Now it looks for a client or a server cluster.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with an integration (zha) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@dmulcahey dmulcahey added this to the 2021.5.1 milestone May 7, 2021
@dmulcahey dmulcahey marked this pull request as ready for review May 7, 2021 12:25
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Adminiuga Adminiuga merged commit 55050bd into home-assistant:dev May 7, 2021
frenck pushed a commit that referenced this pull request May 7, 2021
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
@dmulcahey dmulcahey deleted the dm/zha-better-alarm-panel-support branch November 11, 2022 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants