Skip to content

Allow SimpliSafe startup to retry on failure#50211

Merged
bachya merged 3 commits intohome-assistant:devfrom
bachya:fix-50173
May 7, 2021
Merged

Allow SimpliSafe startup to retry on failure#50211
bachya merged 3 commits intohome-assistant:devfrom
bachya:fix-50173

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented May 7, 2021

Proposed change

This PR allows SimpliSafe setup to retry upon encountering API flakiness. NOTE: this is not the long-term fix; because I haven't had luck in finding a fix for the broken websocket functionality, a broader cleanup of that code will allow for more here. I'm merely including this separately to allow for a simple bugfix beforehand.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this May 7, 2021
@bachya bachya added this to the 2021.5.1 milestone May 7, 2021
@bachya bachya merged commit fec02c8 into home-assistant:dev May 7, 2021
frenck pushed a commit that referenced this pull request May 7, 2021
* Allow SimpliSafe startup to retry on failure

* Update __init__.py

* Black

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
@bachya bachya deleted the fix-50173 branch May 14, 2021 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpliSafe doesn't connect

4 participants