Skip to content

Fix unique_id issue on onewire config entries#50161

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
epenet:onewire-multiple-servers
May 7, 2021
Merged

Fix unique_id issue on onewire config entries#50161
MartinHjelmare merged 1 commit intohome-assistant:devfrom
epenet:onewire-multiple-servers

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented May 6, 2021

Proposed change

The unique_id is available on config entries in SysBus mode, but not in OWServer mode, yet it is used to populate hass.data[DOMAIN]. This causes a conflict when multiple OWServer entries are configured.

This PR instead uses entry_id to populate hass.data[DOMAIN]

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @garbled1, mind taking a look at this pull request as its been labeled with an integration (onewire) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet force-pushed the onewire-multiple-servers branch from 3fd3771 to 456e1ac Compare May 6, 2021 13:00
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented May 6, 2021

cc @klona

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 5d5122c into home-assistant:dev May 7, 2021
@MartinHjelmare
Copy link
Copy Markdown
Member

Should we tag this for a patch release?

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented May 7, 2021

Should we tag this for a patch release?

Yes please - it was reported to me on 2021.4.6 so it would be good to fix in 2021.5

@frenck frenck added this to the 2021.5.1 milestone May 7, 2021
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
@epenet epenet deleted the onewire-multiple-servers branch September 6, 2021 06:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants