Fix unique_id issue on onewire config entries#50161
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom May 7, 2021
Merged
Fix unique_id issue on onewire config entries#50161MartinHjelmare merged 1 commit intohome-assistant:devfrom
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Conversation
3fd3771 to
456e1ac
Compare
Contributor
Author
|
cc @klona |
Member
|
Should we tag this for a patch release? |
Contributor
Author
Yes please - it was reported to me on 2021.4.6 so it would be good to fix in 2021.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The
unique_idis available on config entries in SysBus mode, but not in OWServer mode, yet it is used to populatehass.data[DOMAIN]. This causes a conflict when multiple OWServer entries are configured.This PR instead uses
entry_idto populatehass.data[DOMAIN]Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: