Fix zwave_js websocket api KeyError on unloaded entry#50154
Merged
MartinHjelmare merged 15 commits intodevfrom May 6, 2021
Merged
Fix zwave_js websocket api KeyError on unloaded entry#50154MartinHjelmare merged 15 commits intodevfrom
MartinHjelmare merged 15 commits intodevfrom
Conversation
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration ( |
MartinHjelmare
commented
May 6, 2021
balloob
approved these changes
May 6, 2021
balloob
reviewed
May 6, 2021
| ERR_ID_REUSE = "id_reuse" | ||
| ERR_INVALID_FORMAT = "invalid_format" | ||
| ERR_NOT_FOUND = "not_found" | ||
| ERR_NOT_LOADED = "not_loaded" |
Member
There was a problem hiding this comment.
No need to make this generic since it's only used inside the zwave_js integration. This list is not exclusive, you can make any error code.
Member
Author
There was a problem hiding this comment.
Ok. So far it seemed no custom codes were used, but I'll move it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: