Ignore empty output from MQTT fan's value template#50122
Merged
emontnemery merged 4 commits intohome-assistant:devfrom May 7, 2021
Merged
Ignore empty output from MQTT fan's value template#50122emontnemery merged 4 commits intohome-assistant:devfrom
emontnemery merged 4 commits intohome-assistant:devfrom
Conversation
|
Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration ( |
|
Thanks @jbouwh & @emontnemery ! |
5 tasks
frenck
pushed a commit
that referenced
this pull request
May 7, 2021
* Allow empty payload * Add tests for ignoring empty payload * logging on empty state and osccilation with tests * Improve warning log when invalid value is received
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The purpose is to support the case where speed and preset states are sent on the same topic.
Type of change
Additional information
fanentities to follow the MQTT Fan and Fan Entity breaking changes Koenkk/zigbee2mqtt#7318Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: