Skip to content

Ignore empty output from MQTT fan's value template#50122

Merged
emontnemery merged 4 commits intohome-assistant:devfrom
jbouwh:mqtt-fan-shared-state-topics
May 7, 2021
Merged

Ignore empty output from MQTT fan's value template#50122
emontnemery merged 4 commits intohome-assistant:devfrom
jbouwh:mqtt-fan-shared-state-topics

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented May 5, 2021

Proposed change

  • Ignore empty output from MQTT fan's value template
  • Improve logging
  • Allow shared state topics

The purpose is to support the case where speed and preset states are sent on the same topic.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration (mqtt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@emontnemery emontnemery changed the title Mqtt Fan - allow shared state topics Ignore empty output from MQTT fan's value topic May 5, 2021
@emontnemery emontnemery changed the title Ignore empty output from MQTT fan's value topic Ignore empty output from MQTT fan's value template May 5, 2021
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh 👍

@cmccambridge
Copy link
Copy Markdown

Thanks @jbouwh & @emontnemery !

@emontnemery emontnemery merged commit 7ab5056 into home-assistant:dev May 7, 2021
@frenck frenck added this to the 2021.5.1 milestone May 7, 2021
frenck pushed a commit that referenced this pull request May 7, 2021
* Allow empty payload

* Add tests for ignoring empty payload

* logging on empty state and osccilation with tests

* Improve warning log when invalid value is received
@frenck frenck mentioned this pull request May 7, 2021
@jbouwh jbouwh deleted the mqtt-fan-shared-state-topics branch May 8, 2021 07:02
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MQTT fan integration doesn't allow mixing percentage and preset modes on a single topic

5 participants