Skip to content

Fix group remove selector#50088

Merged
balloob merged 1 commit intohome-assistant:devfrom
tkdrob:group
May 6, 2021
Merged

Fix group remove selector#50088
balloob merged 1 commit intohome-assistant:devfrom
tkdrob:group

Conversation

@tkdrob
Copy link
Copy Markdown
Contributor

@tkdrob tkdrob commented May 4, 2021

Breaking change

Proposed change

Group uses an object id for the remove service requiring an underscore such as "group_test_group". This PR changes the selector to allow the user to use object id. Perhaps group could be updated to use entity id instead?
One grammar correction is also included here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (group) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob added this to the 2021.5.1 milestone May 6, 2021
@balloob balloob merged commit d6c300a into home-assistant:dev May 6, 2021
@balloob
Copy link
Copy Markdown
Member

balloob commented May 6, 2021

Probably a good upgrade to allow both object id (for backwards compat) and entity ID for east selectors. But let's do that in another PR so we can put this in a hot fix

@tkdrob tkdrob deleted the group branch May 6, 2021 13:14
frenck pushed a commit that referenced this pull request May 7, 2021
@frenck frenck mentioned this pull request May 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants