Skip to content

Snapcast config flow#49958

Closed
BarrettLowe wants to merge 2 commits into
home-assistant:devfrom
BarrettLowe:snapcast_config_flow
Closed

Snapcast config flow#49958
BarrettLowe wants to merge 2 commits into
home-assistant:devfrom
BarrettLowe:snapcast_config_flow

Conversation

@BarrettLowe
Copy link
Copy Markdown
Contributor

@BarrettLowe BarrettLowe commented May 1, 2021

Breaking change

Proposed change

This simply adds a config flow for the snapcast integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@BarrettLowe
Copy link
Copy Markdown
Contributor Author

Can somebody help me out here? The code coverage checks are failing due to the auto-formatting.

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 7, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@cgarwood
Copy link
Copy Markdown
Member

There's been some changes to codecov checks recently. Try resolving the merge conflict and it should kick off a new CI run

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Feb 28, 2022
@frenck frenck added the config-flow This integration migrates to the UI by adding a config flow label Mar 19, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 6, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jul 6, 2022
@github-actions github-actions Bot closed this Jul 15, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality config-flow This integration migrates to the UI by adding a config flow has-tests integration: snapcast stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants