Move ZHA config panel section translations to the backend#49816
Merged
balloob merged 3 commits intohome-assistant:devfrom Apr 30, 2021
Merged
Move ZHA config panel section translations to the backend#49816balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
bot
added
integration: zha
small-pr
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with an integration ( |
9 tasks
balloob
reviewed
Apr 28, 2021
| "single_instance_allowed": "[%key:common::config_flow::abort::single_instance_allowed%]" | ||
| } | ||
| }, | ||
| "config_panel": { |
Member
There was a problem hiding this comment.
I don't think that this makes sense as long as the actual panel code lives in the frontend. Or are these strings passed to the frontend from the backend?
CC @bramkragten
Member
There was a problem hiding this comment.
They use ha-form and get the actual data/fields from the backend, so I think it makes sense to have the translations on the backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR moves the translations for the ZHA configuration panel sections to the backend so that PR's don't have to be opened in Both the frontend and backend repos when new configuration panel sections are added.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: