Only initialize Nuki configurations

[darkson95]

Breaking change

No breaking changes, only a bug fix.

Proposed change

The Nuki integration initializes now only lock-configurations if it has the following 3 keys in it: host, port, token

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes Nuki - "New devices discovered" after restart #48358
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[homeassistant]

Hi @darkson95,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @pschmitt, @pvizeli, @pree, mind taking a look at this pull request as its been labeled with an integration (nuki) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[pree]

This wouldn't import configurations when they don't specify a port (e.g. using the default port)?

[darkson95]

Yes, but if you don't specify a port, you will get an error like @remyderuysscher (#48358 (comment)). If you configure Nuki over the UI the port is set.

[pree]

Couldn't we just set the default port then? Otherwise it wouldn't import configurations that don't specify a port (should be the bulk of them). The configuration import should also be removed in the Juni release as it will be deprecated for 2 releases then.

[balloob]

For now it's an ok bug fix but this is the complete wrong approach.

Platforms don't have to be configured under their domain, they can be configured under light bla: in YAML. That's being missed here. The only way to do this correctly is to have an async_setup_platform to support the old config and then import that.

For now this can go in the hot fix, but this should be refactored.

[pvizeli]

I think the next release will drop yaml support, right @pree ?

[pree]

I think the next release will drop yaml support, right @pree ?

Yes, I will open a PR soon for this.