Skip to content

Reduce precision in returned fronius values to meaningful digits#49382

Merged
janiversen merged 1 commit intohome-assistant:devfrom
nielstron:patch-high-precision
May 23, 2021
Merged

Reduce precision in returned fronius values to meaningful digits#49382
janiversen merged 1 commit intohome-assistant:devfrom
nielstron:patch-high-precision

Conversation

@nielstron
Copy link
Copy Markdown
Contributor

@nielstron nielstron commented Apr 18, 2021

Proposed change

As per request of a user, the number of digits in returned floating point values is reduced with this patch.

This makes sense as per default, the Fronius module returns values that have up to 10 digits which usually is only due to conversion of certain limited-bit values to the JSON format. Examples may be found below

         "SMARTMETER_POWERAPPARENT_01_F64" : 1768.1400000000001,
         "SMARTMETER_POWERAPPARENT_MEAN_01_F64" : 1723.7711666666655,
         "SMARTMETER_POWERAPPARENT_MEAN_SUM_F64" : 1768.1400000000001,

The fronius native interface shows not more than two digits and since this amount of digits drastically reduces readability, it is automatically removed in this module.
The backend package is not changed as the very precise result might be still of importance in other use cases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Reduce precision in returned values to meaningful digits Reduce precision in returned fronius values to meaningful digits Apr 18, 2021
Copy link
Copy Markdown
Contributor

@Drafteed Drafteed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier, more clear and reduced get:

self._state = state.get("value")
if isinstance(self._state, float):
    self._state = round(self._state, 2)

@nielstron nielstron force-pushed the patch-high-precision branch from c383fd1 to b3df136 Compare April 28, 2021 19:52
Copy link
Copy Markdown
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@janiversen janiversen merged commit f0cd87e into home-assistant:dev May 23, 2021
@janiversen
Copy link
Copy Markdown
Member

thanks.

@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants