Explicitly define all methods in ConfigFlow#49341
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Apr 17, 2021
Merged
Explicitly define all methods in ConfigFlow#49341MartinHjelmare merged 1 commit intohome-assistant:devfrom
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Conversation
MartinHjelmare
requested changes
Apr 17, 2021
|
|
||
| async def async_step_zeroconf( | ||
| self, user_input: ConfigType | None = None | ||
| self, discovery_info: ConfigType | None = None |
Member
There was a problem hiding this comment.
The discovery info should never be None.
Member
There was a problem hiding this comment.
We can address this in a follow up too if wanted.
Member
Author
There was a problem hiding this comment.
Yes, I know. The typing in that component is already pretty broken and it's not checked anyway. So I think right now it's not worth fixing it before we can enable type checks here. That I'm trying to do in #49270
Member
Author
There was a problem hiding this comment.
But yeah, let's annotate this method correctly at least.
Member
There was a problem hiding this comment.
Ok, let's fix this separately then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Unfortunately,
mypyandpylintare unable to analyse such aliased methods. This causes# type: ignorewas needed in some places and somepylintwarnings were hidden.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: