Skip to content

Add support for Velux light devices#49338

Merged
frenck merged 8 commits intohome-assistant:devfrom
bramstroker:feature/veluxlight
Jul 24, 2021
Merged

Add support for Velux light devices#49338
frenck merged 8 commits intohome-assistant:devfrom
bramstroker:feature/veluxlight

Conversation

@bramstroker
Copy link
Contributor

Proposed change

I have a Velux KLF 200 with 4 windows, 4 blinds and 4 led spots connected. The integration was missing support to control my lights. This PR adds support

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @bramstroker,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with an integration (velux) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bramstroker bramstroker changed the title Feature/veluxlight Add support for Velux light devices Apr 17, 2021
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 19, 2021
@bramstroker
Copy link
Contributor Author

Not stale

@github-actions github-actions bot removed the stale label May 19, 2021
@jirkapas
Copy link

How long does it usually take for a pull request like this to be merged into home assistant?

bramstroker and others added 3 commits July 24, 2021 09:28
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@frenck frenck self-requested a review July 24, 2021 12:04
@bramstroker
Copy link
Contributor Author

Rebased the PR and resolved latest comments. And did some final testing. Works on my machine ;-)

@bramstroker
Copy link
Contributor Author

pipeline failed, should be fixed now hopefully.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bramstroker 👍

@frenck frenck merged commit 87e41e8 into home-assistant:dev Jul 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants